[PATCH] D124455: [X86] Check the address in machine verifier

Wed Apr 27 03:12:17 PDT 2022

pengfei added inline comments.

================
Comment at: llvm/test/CodeGen/MIR/X86/machine-verifier-address.mir:1
+# RUN: not --crash llc -march=x86-64 -run-pass none -o /dev/null %s 2>&1 | FileCheck %s
+# This test ensures that the address is checked in machine verifier.
----------------
skan wrote:
> skan wrote:
> > pengfei wrote:
> > > I'm curious why we can verify it without option `-verify-machineinstrs`?
> > Because when you feed a MIR to llc w/ option `run-pass`,  the verification for MIR is forced to run.
> See https://reviews.llvm.org/rGc7bf20403bee51789f3691f0bf9bc7d7216f3f28 for details.
Good to know, thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124455/new/

https://reviews.llvm.org/D124455