[PATCH] D123599: [DebugInfo][InstrRef] Describe value sizes when spilt to stack

[Jeremy Morse via Phabricator via llvm-commits]

jmorse marked 2 inline comments as done.
jmorse added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:879-880
+      unsigned DerefSize = ValueSize / 8;
+      if (Var.getFragment()) {
+        auto Fragment = Var.getFragment();
+        unsigned VariableSize = Fragment->SizeInBits / 8;
----------------
Orlando wrote:
> nit: `if (auto Fragment = Var.getFragment())` more idiomatic?
Yup, will fold in,


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:888
+        }
+      }
+
----------------
Orlando wrote:
> nit: I think adding `InBits` / `InBytes` to these variable names would improve readability here
Yup, will fold in.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123599/new/

https://reviews.llvm.org/D123599