[PATCH] D124445: [llvm-ar] Modify usage printouts to use the correct toolname

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Two test nits, otherwise looks fine to me.



================
Comment at: llvm/test/tools/llvm-ar/tool-name.test:15-17
+# DEFAULT: USAGE: llvm-ar
+# VERSION: USAGE: llvm-ar-9
+# SUFFIX: USAGE: ar
----------------
You should add something like `{{ }}` at the end of these lines, to show that there is nothing else after the tool name. In particular, whether `.exe` is present in the SUFFIX case.


================
Comment at: llvm/test/tools/llvm-ar/tool-name.test:18
+# SUFFIX: USAGE: ar
+# ARM: arm-pokymllib32-linux-gnueabi-llvm-ar-9
----------------
What's the purpose of this line? To show that the prefix is printed as much as the suffix, or something more specific?

Also, it's missing "USAGE:" unlike the other patterns.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124445/new/

https://reviews.llvm.org/D124445