[PATCH] D124266: [lld/elf] fix quote usage in section names

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 26 23:28:24 PDT 2022


MaskRay added a comment.

In D124266#3474336 <https://reviews.llvm.org/D124266#3474336>, @royger wrote:

> In D124266#3472842 <https://reviews.llvm.org/D124266#3472842>, @MaskRay wrote:
>
>>> [lld/elf] fix quote usage in section names
>>
>> "Support " is more appropriate. We don't claim this was supported so we cannot consider this as a bug.
>
> OK, I've used fix because GNU ld does support quoted section names, and lld claims to be compatible.
>
> Can this be fixed at commit please? Are there any other steps I should do to get this committed?
>
> Thanks

You may change the subject of the differential.

There are number of comments for tests which haven't been marked as done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124266/new/

https://reviews.llvm.org/D124266



More information about the llvm-commits mailing list