[PATCH] D124498: AArch64: change the location of the Swift async frame record

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 26 23:20:10 PDT 2022


mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.

LGTM, but I think it'd be good to mention Windows in the commit message subject too, not only in the body of the commit message.

Also, the commit message mentions that Windows prologues store x30, x29 ... in descending numerical order on the stack - while the testcase you add actually doesn't - this threw me off for a bit. But since the function is marked `nounwind`, it doesn't apply those changes but keeps things more like on other platforms here. (Also, if the `nounwind` attribute is removed, the function probably isn't unwindable by the Windows unwinder anyway, due to `orr x29, x29, #0x1000000000000000` which can't be mapped to any SEH unwind opcode.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124498/new/

https://reviews.llvm.org/D124498



More information about the llvm-commits mailing list