[PATCH] D122207: [IROutliner][IRSim] Add all outlined region basic blocks to canonical numbering to add basic blocks to generated PHINode numbering generation.

Tue Apr 26 22:39:21 PDT 2022

uabelho added a comment.

In D122207#3466709 <https://reviews.llvm.org/D122207#3466709>, @uabelho wrote:

> Hi!
>
> The following starts to crash with this patch, and it still crashes on current top of tree 036aeac36c <https://reviews.llvm.org/rG036aeac36c00f4390e861118f536150b366beaaf>:
>
>   opt -passes='require<ir-similarity>' -o /dev/null bbi-68950.ll
>
> We get
>
>   opt: ../include/llvm/Support/Casting.h:269: typename cast_retty<X, Y *>::ret_type llvm::cast(Y *) [X = llvm::Instruction, Y = llvm::Value]: Assertion `isa<X>(Val) && "cast<Ty>() argument of incompatible type!"' failed.
>   PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
>   Stack dump:
>   0.	Program arguments: build-all/bin/opt -passes=require<ir-similarity> -o /dev/null /home/uabelho/bbi-68950.ll
>   Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
>   build-all/bin/opt(_ZN4llvm3sys15PrintStackTraceERNS_11raw_ostreamEi+0x23)[0x2cbf503]
>   build-all/bin/opt(_ZN4llvm3sys17RunSignalHandlersEv+0xee)[0x2cbd17e]
>   build-all/bin/opt[0x2cbf886]
>   /lib64/libpthread.so.0(+0xf630)[0x7f7bebb82630]
>   /lib64/libc.so.6(gsignal+0x37)[0x7f7be92c9387]
>   /lib64/libc.so.6(abort+0x148)[0x7f7be92caa78]
>   /lib64/libc.so.6(+0x2f1a6)[0x7f7be92c21a6]
>   /lib64/libc.so.6(+0x2f252)[0x7f7be92c2252]
>   build-all/bin/opt(_ZN4llvm12IRSimilarity21IRSimilarityCandidate27createCanonicalRelationFromERS1_RNS_8DenseMapIjNS_8DenseSetIjNS_12DenseMapInfoIjvEEEES6_NS_6detail12DenseMapPairIjS7_EEEESC_+0x11e6)[0x1b835d6]
>   build-all/bin/opt(_ZN4llvm12IRSimilarity22IRSimilarityIdentifier14findCandidatesERSt6vectorIPNS0_17IRInstructionDataESaIS4_EERS2_IjSaIjEE+0xa51)[0x1b84631]
>   build-all/bin/opt(_ZN4llvm12IRSimilarity22IRSimilarityIdentifier14findSimilarityERNS_6ModuleE+0xec)[0x1b854ac]
>   build-all/bin/opt(_ZN4llvm20IRSimilarityAnalysis3runERNS_6ModuleERNS_15AnalysisManagerIS1_JEEE+0x181)[0x1b85a81]
>   build-all/bin/opt[0x2fe4320]
>   build-all/bin/opt(_ZN4llvm15AnalysisManagerINS_6ModuleEJEE13getResultImplEPNS_11AnalysisKeyERS1_+0x20e)[0x245fb1e]
>   build-all/bin/opt[0x2ff1258]
>   build-all/bin/opt[0x2ff109d]
>   build-all/bin/opt(_ZN4llvm11PassManagerINS_6ModuleENS_15AnalysisManagerIS1_JEEEJEE3runERS1_RS3_+0x208)[0x245d3d8]
>   build-all/bin/opt(_ZN4llvm15runPassPipelineENS_9StringRefERNS_6ModuleEPNS_13TargetMachineEPNS_21TargetLibraryInfoImplEPNS_14ToolOutputFileES8_S8_S0_NS_8ArrayRefIS0_EENS9_INS_10PassPluginEEENS_8opt_tool10OutputKindENSD_12VerifierKindEbbbbb+0x3f9f)[0x78657f]
>   build-all/bin/opt(main+0x3fad)[0x7972cd]
>   /lib64/libc.so.6(__libc_start_main+0xf5)[0x7f7be92b5555]
>   build-all/bin/opt[0x780ec0]
>
> F22867508: bbi-68950.ll <https://reviews.llvm.org/F22867508>

@AndrewLitteken: I wrote an issue about this new crash here:
https://github.com/llvm/llvm-project/issues/55131

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122207/new/

https://reviews.llvm.org/D122207