[PATCH] D124008: llvm-reduce: Support multiple MachineFunctions

[Matthias Braun via Phabricator via llvm-commits]

MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

> Looks fine to me though someone with better insight into MMI could probably provide better feedback.

Don't be afraid and press the accept button ;-)    I know it's always a balancing act but it feels to me that newcomers tend to be too cautious... Given that this seems to be a less critical component of LLVM. (Speaking as a person who has way too many reviews in his phabricator list...).

Anyway this change LGTM.



================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceInstructionsMIR.cpp:132
+  for (const Function &F : WorkItem.getModule()) {
+    if (auto *MF = WorkItem.MMI->getMachineFunction(F))
+      extractInstrFromFunction(O, *MF);
----------------
avoid auto?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124008/new/

https://reviews.llvm.org/D124008