[PATCH] D122287: [XCOFF] support writing sections, relocations and symbols for XCOFF64.

[Esme Yi via Phabricator via llvm-commits]

Esme added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/MCTargetDesc/PPCXCOFFObjectWriter.cpp:84
+    case MCSymbolRefExpr::VK_PPC_L:
+      return {XCOFF::RelocationType::R_TOCL, 15};
+    }
----------------
shchenz wrote:
> Should we handle `RelocationType::R_TOCU`? I guess it may be generated in large code model(`-mcmodel=large`).
`fixup_ppc_half16ds` and `fixup_ppc_half16dq` may only correspond to `lo16` of instrs, not `ha16`, so we shouldn't deal with `RelocationType::R_TOCU` here.

I have added the corresponding  large code model test in `llvm/test/CodeGen/PowerPC/aix-xcoff-reloc-large.ll`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122287/new/

https://reviews.llvm.org/D122287