[PATCH] D124247: [Trivial Dead] Consider any non volatile load as trivially dead independent on ordering

Serguei Katkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 26 20:21:56 PDT 2022


skatkov added a comment.

Sequential consistency adds total order of all seq_cst operations to release-acquire semantic. However If load is not used its total order does not matter, so only acquire semantic plays role here.

But I understand your point.
All this stuff related to synchronization is complicated. The worst thing is that in this area it is easier to reject something with an example than to prove that such example is not possible.

Don't you think that adding the implementation above under the flag is more or less safe if it is off by default and we can consider it switching on some day in future. At least we can try to play with it...
Meaning I'd like to add it only if there is no visible failure in my analysis.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124247/new/

https://reviews.llvm.org/D124247



More information about the llvm-commits mailing list