[PATCH] D124455: [X86] Check the address in machine verifier

[Kan Shengchen via Phabricator via llvm-commits]

skan added a comment.

In D124455#3476213 <https://reviews.llvm.org/D124455#3476213>, @craig.topper wrote:

> Do we have test coverage that the expensive checks bot runs that would have caught the gather+opaque ptr issue that motivated this patch?
>
> I'm not opposed to this patch, just wondering if it is enough to help us find issues.



In D124455#3476213 <https://reviews.llvm.org/D124455#3476213>, @craig.topper wrote:

> Do we have test coverage that the expensive checks bot runs that would have caught the gather+opaque ptr issue that motivated this patch?
>
> I'm not opposed to this patch, just wondering if it is enough to help us find issues.

I think so. https://github.com/llvm/llvm-project/blob/main/llvm/lib/CodeGen/TargetPassConfig.cpp#L809
Machine verify is enabled when the macro `EXPENSIVE_CHECKS` is on, so we can expose the "gather+opaque ptr" issue at ISEL stage w/ this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124455/new/

https://reviews.llvm.org/D124455