[PATCH] D124418: [CHR] Skip region containing llvm.coro.id

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu accepted this revision.
ChuanqiXu added a comment.
This revision is now accepted and ready to land.

Thanks for the explanation. This fix LGTM.



================
Comment at: llvm/lib/Transforms/Instrumentation/ControlHeightReduction.cpp:776-778
+    // If we encounter llvm.coro.id, skip this region because if the basic block
+    // is cloned, we end up inserting a token type PHI node to the block with
+    // llvm.coro.begin.
----------------
Maybe it is better to add a FIXME/NOTE to say we could hoist the coro.id intrinsic to the pos-dominator frontier.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124418/new/

https://reviews.llvm.org/D124418