[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

[Chris Bieneman via Phabricator via llvm-commits]

beanz added reviewers: compnerd, ldionne, smeenai.
beanz added subscribers: smeenai, ldionne, compnerd.
beanz added a comment.

I don't want to roadblock or say "no we absolutely can't let this in", _but_... Apple Clang and Swift have long been the only reason we've kept this code alive. I didn't have the time to fix Apple Clang years ago, and nobody has made the effort since.

I'm very aware of the technical debt of build-script, and I don't want LLVM to be in a position where we need to continue supporting confusing build scenarios because the Swift build is too complex to fix.

I'll defer to whatever @phosek, @compnerd, @smeenai, and @ldionne feel is right here, but I do believe at some point in the future we should delete this code path, whether downstream users have migrated or not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124474/new/

https://reviews.llvm.org/D124474