[PATCH] D124472: [AMDGPU] Properly mark MUBUF and FLAT LDS DMA instructions. NFC.

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/BUFInstructions.td:518
+  let VALU = isLds;
+  let hasSideEffects = isLds;
 }
----------------
arsenm wrote:
> Loads and stores shouldn't be marked hasSideEffects, only mayLoad/mayStore
How do you suggest to mark that it can read and write virtually any memory?
Note that atomics have hasSideEffects flag.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124472/new/

https://reviews.llvm.org/D124472