[PATCH] D123972: [RISCV] Add isCommutable to FADD/FMUL/FMIN/FMAX/FEQ.

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 26 12:08:21 PDT 2022


reames added a comment.

LGTM, though a second read from someone familiar with floating point is probably warranted.

fadd and fmul are clearly okay.

Reading the RISCV specification, the FEQ case appears okay.  The FMIN and FMAX cases give me the most pause, but the description seems to be commutative.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123972/new/

https://reviews.llvm.org/D123972



More information about the llvm-commits mailing list