[llvm] 3a9ae9c - [RISCV] Add out of range immediate tests for shifts and rotates on rv64.

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 26 10:55:30 PDT 2022


Author: Craig Topper
Date: 2022-04-26T10:55:14-07:00
New Revision: 3a9ae9cf7c341ff329550a5bcac8362715d3f4b3

URL: https://github.com/llvm/llvm-project/commit/3a9ae9cf7c341ff329550a5bcac8362715d3f4b3
DIFF: https://github.com/llvm/llvm-project/commit/3a9ae9cf7c341ff329550a5bcac8362715d3f4b3.diff

LOG: [RISCV] Add out of range immediate tests for shifts and rotates on rv64.

We were only testing the shared instruction mnemonics in rv32 tests.

Reviewed By: reames

Differential Revision: https://reviews.llvm.org/D124460

Added: 
    

Modified: 
    llvm/test/MC/RISCV/rv64i-invalid.s
    llvm/test/MC/RISCV/rv64zbbp-invalid.s

Removed: 
    


################################################################################
diff  --git a/llvm/test/MC/RISCV/rv64i-invalid.s b/llvm/test/MC/RISCV/rv64i-invalid.s
index 8c259c11b707f..deb8ea54fde35 100644
--- a/llvm/test/MC/RISCV/rv64i-invalid.s
+++ b/llvm/test/MC/RISCV/rv64i-invalid.s
@@ -6,6 +6,11 @@ slliw a0, a0, 32 # CHECK: :[[@LINE]]:15: error: immediate must be an integer in
 srliw a0, a0, -1 # CHECK: :[[@LINE]]:15: error: immediate must be an integer in the range [0, 31]
 sraiw a0, a0, -19 # CHECK: :[[@LINE]]:15: error: immediate must be an integer in the range [0, 31]
 
+## uimm6
+slli a0, a0, 64 # CHECK: :[[@LINE]]:14: error: immediate must be an integer in the range [0, 63]
+srli a0, a0, -1 # CHECK: :[[@LINE]]:14: error: immediate must be an integer in the range [0, 63]
+srai a0, a0, -19 # CHECK: :[[@LINE]]:14: error: immediate must be an integer in the range [0, 63]
+
 ## simm12
 addiw a0, a1, -2049 # CHECK: :[[@LINE]]:15: error: operand must be a symbol with %lo/%pcrel_lo/%tprel_lo modifier or an integer in the range [-2048, 2047]
 ld ra, 2048(sp) # CHECK: :[[@LINE]]:8: error: operand must be a symbol with %lo/%pcrel_lo/%tprel_lo modifier or an integer in the range [-2048, 2047]
@@ -16,5 +21,10 @@ slliw a0, a0, %lo(1) # CHECK: :[[@LINE]]:15: error: immediate must be an integer
 srliw a0, a0, %lo(a) # CHECK: :[[@LINE]]:15: error: immediate must be an integer in the range [0, 31]
 sraiw a0, a0, %hi(2) # CHECK: :[[@LINE]]:15: error: immediate must be an integer in the range [0, 31]
 
+## uimm6
+slli a0, a0, %lo(1) # CHECK: :[[@LINE]]:14: error: immediate must be an integer in the range [0, 63]
+srli a0, a0, %lo(a) # CHECK: :[[@LINE]]:14: error: immediate must be an integer in the range [0, 63]
+srai a0, a0, %hi(2) # CHECK: :[[@LINE]]:14: error: immediate must be an integer in the range [0, 63]
+
 ## simm12
 addiw a0, a1, %hi(foo) # CHECK: :[[@LINE]]:15: error: operand must be a symbol with %lo/%pcrel_lo/%tprel_lo modifier or an integer in the range [-2048, 2047]

diff  --git a/llvm/test/MC/RISCV/rv64zbbp-invalid.s b/llvm/test/MC/RISCV/rv64zbbp-invalid.s
index a8c1d4746cd13..04d9b9984169f 100644
--- a/llvm/test/MC/RISCV/rv64zbbp-invalid.s
+++ b/llvm/test/MC/RISCV/rv64zbbp-invalid.s
@@ -9,6 +9,8 @@ roriw t0, t1 # CHECK: :[[@LINE]]:1: error: too few operands for instruction
 # Immediate operand out of range
 roriw t0, t1, 32 # CHECK: :[[@LINE]]:15: error: immediate must be an integer in the range [0, 31]
 roriw t0, t1, -1 # CHECK: :[[@LINE]]:15: error: immediate must be an integer in the range [0, 31]
+rori t0, t1, 64 # CHECK: :[[@LINE]]:14: error: immediate must be an integer in the range [0, 63]
+rori t0, t1, -1 # CHECK: :[[@LINE]]:14: error: immediate must be an integer in the range [0, 63]
 # Too few operands
 packw t0, t1 # CHECK: :[[@LINE]]:1: error: too few operands for instruction
 # Too few operands


        


More information about the llvm-commits mailing list