[PATCH] D124153: [CMake] Change default CMAKE_BUILD_TYPE to Release

[Tobias Hieta via Phabricator via llvm-commits]

thieta added a comment.

In D124153#3471610 <https://reviews.llvm.org/D124153#3471610>, @erichkeane wrote:

> I'm OK with #1 and #2, but note that the combo in #3 is not ALWAYS broken, just if you don't have enough memory or are running too many link jobs at the same time.  I'm not sure we want it to be an 'error'.

In my anecdotal information this configuration is almost ALWAYS broken. I just tested this on my system with 32GB RAM. With all defaults and it can't build correctly and dies when the linker runs out of memory. So our stock configuration is bad even on a pretty high-end system with bfd. This is using GCC 11.2.1 and binutils 2.38 - so pretty recent stuff.

Maybe we can tweak the default configuration to not make this happen, but if we don't I really would like that error there (which can be circumvented with a flag).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124153/new/

https://reviews.llvm.org/D124153