[PATCH] D124428: [RISCV] Add RV64Zbs invalid tests
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 26 08:26:11 PDT 2022
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/test/MC/RISCV/rv64zbs-invalid.s:1
+# RUN: not llvm-mc -triple riscv64 -mattr=+zbs < %s 2>&1 | FileCheck %s
+
----------------
Pretty-box wrote:
> craig.topper wrote:
> > Can you test with riscv32 as well? The immediate ranges are different.
> rv32zbs-invalid.s file already exists, but rv64zbs-invalid.s file is missing
Thanks. That would have been good information to put in the patch description.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124428/new/
https://reviews.llvm.org/D124428
More information about the llvm-commits
mailing list