[PATCH] D122421: [z/OS] Clean up some z/OS testcases.

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 26 06:59:20 PDT 2022


uweigand added inline comments.


================
Comment at: llvm/test/CodeGen/SystemZ/call-zos-vararg.ll:17
+; CHECK-DAG:   llihf 0, 1074118262
+; CHECK-DAG:   oilf  0, 3367254360
+; CHECK-DAG:   llihf 3, 1074340036
----------------
This may be a bit too flexible.  The CHECK-DAG here would allow the two instructions above to be swapped, in which case the semantics would be incorrect.

The same holds for a number of other tests below.   Maybe a better way would be to use auto-generated CHECK statements for this file?  (Via utils/update_llc_test_checks.py)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122421/new/

https://reviews.llvm.org/D122421



More information about the llvm-commits mailing list