[PATCH] D113497: [IPSCCP] Support unfeasible default dests for switch.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 26 04:43:07 PDT 2022


fhahn added a comment.

In D113497#3157893 <https://reviews.llvm.org/D113497#3157893>, @fhahn wrote:

> In D113497#3155755 <https://reviews.llvm.org/D113497#3155755>, @lebedev.ri wrote:
>
>> LG.
>>
>> If SCCP runs again, will it then again create a new unreachable block
>> for the default that is already pointing at the unreachable block?
>> Should it not do such redundant work?
>
> Good point. In practice I think IPSCCP is only run twice when doing LTO, so it's probably not a big deal. But let me check if the default dst is already unreachable.

If the default destination is already only an unreachable block and unfeasible, it the original block will be removed as part of the clean-up. re-using the block would be difficult, because it's been already marked for deletion and I think making changes to that is probably not worth the trouble.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113497/new/

https://reviews.llvm.org/D113497



More information about the llvm-commits mailing list