[PATCH] D124416: [SPIRV] Add the SPIRV-specific intrinsics, two passes and tests

Ilia Diachkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 26 04:06:52 PDT 2022


iliya-diyachkov marked 2 inline comments as done.
iliya-diyachkov added inline comments.


================
Comment at: llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp:58-61
+  void preprocessCompositeConstants();
+  CallInst *buildIntrCall(Intrinsic::ID IntrID, ArrayRef<Type *> Types,
+                          ArrayRef<Value *> Args) {
+    auto *IntrFn = Intrinsic::getDeclaration(F->getParent(), IntrID, Types);
----------------
arsenm wrote:
> CreateUnaryIntrinsic?
Thanks. It doesn't always have a unary argument, so I'm changing it to CreateIntrinsic.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124416/new/

https://reviews.llvm.org/D124416



More information about the llvm-commits mailing list