[PATCH] D123848: [RS4GC] Don't clone BDV if its inputs are not derived

[Serguei Katkov via Phabricator via llvm-commits]

skatkov added a comment.

Please go through all comments in findBasePointer and verify that they are up to date with you changes...



================
Comment at: llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp:749
     };
+    auto markDifferentBases = [&]() {
+      Status = BDVState::DifferentBases;
----------------
This is redundant, just use in place.


================
Comment at: llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp:770
       return markConflict();
-    // Other is base as well.
-    assert(Other.isBase() && "Unknown state");
-    // If bases are different - Conflict.
-    if (getBaseValue() != Other.getBaseValue())
+    if (isBaseOrDerived() && Other.isBaseOrDerived() &&
+        getBaseValue() == Other.getBaseValue()) {
----------------
Add a comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123848/new/

https://reviews.llvm.org/D123848