[PATCH] D124378: [X86][AMX] combine tile cast and load/store instruction.

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/lib/Target/X86/X86LowerAMXType.cpp:949
+  std::tie(Row, Col) = getShape(II, OpNo);
+  IRBuilder<> Builder(Cast);
+  // Use the maximun column as stride.
----------------
I just realize that the tileload should insert before load instruction instead of cast. If there is store between load and cast, this transform is not correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124378/new/

https://reviews.llvm.org/D124378