[PATCH] D124156: [flang][OpenMP] Added parser support for in_reduction clause on OpenMP Task directive

[Nimish Mishra via Phabricator via llvm-commits]

NimishMishra added a comment.

In D124156#3473639 <https://reviews.llvm.org/D124156#3473639>, @shraiysh wrote:

> Why is the file name "omp-block-construct-unparse.f90"? We want to test in_reduction clause, why not add an omp task pragma unparsing test (if not already there). The name of the testfile is a little misleading. Same thing for the parse-tree tests. Rest LGTM.

I actually checked the current files in https://github.com/llvm/llvm-project/tree/main/flang/test/Parser and wondered if I should include one file that would contain all tests related to block constructs that we include in future. Many block construct related directives are absent in the `flang/test/Parser` directory; but I wondered we can condense any block directive incoming in future into this file. Let me know what you think about this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124156/new/

https://reviews.llvm.org/D124156