[PATCH] D123828: [mlir][OpenMP] Add omp.cancel and omp.cancellationpoint.

[Peixin Qiao via Phabricator via llvm-commits]

peixin added a comment.

Mostly LGTM.



================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:1808
 CHECK_SIMPLE_CLAUSE(Compare, OMPC_compare)
+CHECK_SIMPLE_CLAUSE(CancelConstructType, OMPC_cancel_construct_type)
 
----------------
Niy: Would CancellationConstructType be better? Both cancel construct and cancellation point construct are cancellation constructs.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMP.td:176
+    let enumClauseValue = "CancelConstructType";
+    let allowedClauseValues = [
+    OMP_CANCEL_CONSTRUCT_Parallel,
----------------
Nit


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123828/new/

https://reviews.llvm.org/D123828