[PATCH] D121881: [RISCV][RVV] Select unmasked TU RVV pseudos in a DAG post-process

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:2285
+  if (IsTA) {
+    const MCInstrDesc &UnmaskedMCID = TII->get(I->UnmaskedPseudo);
 
----------------
Could shorten the checks in the assert by doing

```
uint64_t TSFlags = TII->get(I->UnmaskedPseudo).TSFlags;
```


================
Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:2295
+  } else {
+    const MCInstrDesc &UnmaskedTuMCID = TII->get(I->UnmaskedTuPseudo);
+
----------------
Same here


================
Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.h:194
   uint16_t UnmaskedPseudo;
+  uint16_t UnmaskedTuPseudo;
   uint8_t MaskOpIdx;
----------------
Probably should be UnmaskedTUPseudo, since TU is an abbreviation and not a word.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121881/new/

https://reviews.llvm.org/D121881