[PATCH] D124361: [Coroutines] Add coro_maychange intrinsic to solve TLS problem (2/5)

Chuanqi Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 25 19:01:54 PDT 2022


ChuanqiXu added inline comments.


================
Comment at: llvm/lib/Transforms/Coroutines/CoroEarly.cpp:265
+
+        Use.set(CallInst::Create(MaychangeFn, {&GV}, GV.getName(), UserInst));
+      }
----------------
efriedma wrote:
> UserInst might not be a legal insertion point for a call if it's a PHI node.
Oh, good Catcha!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124361/new/

https://reviews.llvm.org/D124361



More information about the llvm-commits mailing list