[PATCH] D124378: [X86][AMX] combine tile cast and load/store instruction.

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added a comment.

Combine usually make sense. Not sure the case load/store has special attributes, e.g. volatile. The new amx load/store may miss them.



================
Comment at: llvm/lib/Target/X86/X86LowerAMXType.cpp:947
+  if (!isAMXInstrinsic(II))
+    return;
+  std::tie(Row, Col) = getShape(II, OpNo);
----------------
>return
Here has chance to get shape for other user.


================
Comment at: llvm/lib/Target/X86/X86LowerAMXType.cpp:994
+      // Set the operand is null so that load instruction can be erased.
+      Cast->setOperand(0, nullptr);
+      Load->eraseFromParent();
----------------
How about the Cast has other non load users


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124378/new/

https://reviews.llvm.org/D124378