[PATCH] D124414: [Support] Factor out isCrash from throwIfCrash

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 25 17:44:13 PDT 2022


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

In D124414#3473423 <https://reviews.llvm.org/D124414#3473423>, @dblaikie wrote:

> this'd slightly change behavior, right? Now something that isn't a Win32 crash but is a unix crash would call the win32 raise exception, yeah?

Ah, sorry, misread. I see both the conditions and the raise handling are conditional and matched, so it looks OK.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124414/new/

https://reviews.llvm.org/D124414



More information about the llvm-commits mailing list