[PATCH] D124121: [DebugInfo] Give warning instead of error for premature terminator in .debug_aranges section.

[Junfeng Dong via Phabricator via llvm-commits]

junfd added a comment.

In D124121#3472754 <https://reviews.llvm.org/D124121#3472754>, @dblaikie wrote:

> Might be easier to understand with the upstream changes to llvm-profdata. "Prior to your change, "warning" level issues were reported via the same callback as "recoverable errors" within the DWARFDebugAranges code." - maybe llvm-profdata could just treat "recoverable errors" as warnings, effectively?

Thanks for commenting this. The call stack is deep. I didn't see a way to configure this in llvm-profgen without changing all of these functions on the path. Even it is possible,  I think current fix is more efficient.  What's more, there are two levels of error messages during exacting address ranges sections (in function DWARFDebugArangeSet::extract). some are better to be reported as error even "recoverable", some like this one only needs warning. It is more reasonable to make llvm library give consistent message. current llvm-dwarfdump give warning because it call  DWARFDebugArangeSet::extract through other path which use WarningHandler. F22903335: image.png <https://reviews.llvm.org/F22903335>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124121/new/

https://reviews.llvm.org/D124121