[PATCH] D122268: Add PointerType analysis for DirectX backend

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 25 14:47:20 PDT 2022


kuhar added inline comments.


================
Comment at: llvm/unittests/Target/DirectX/PointerTypeAnalysisTests.cpp:184-185
+        FAIL();
+    } else
+      FAIL();
+  }
----------------
nit: I think the convention is that we either have all `if`/`else` bodies in a chain with or without braces. So
```
if (...)
  ...;
else
  ...;
```

and 
```
if (...) {
  ...
} else {
  ...;
}
```

are fine, but:
```
if (...) {
  ...;
} else
  ...;
```

is not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122268/new/

https://reviews.llvm.org/D122268



More information about the llvm-commits mailing list