[PATCH] D122268: Add PointerType analysis for DirectX backend

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar added inline comments.


================
Comment at: llvm/lib/Target/DirectX/PointerTypeAnalysis.cpp:42
+      if (NewPointeeTy->isOpaquePointerTy())
+        return TypedPointerType::get(classifyPointerType(User),
+                                     V->getType()->getPointerAddressSpace());
----------------
beanz wrote:
> kuhar wrote:
> > What's the worst case for the number of recursive calls? Could a pathological shader cause a stack overflow?
> Since the source language doesn't support pointers, we should rarely see more than two levels of indirection.
OK, that makes sense to me. Could you add this as a comment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122268/new/

https://reviews.llvm.org/D122268