[PATCH] D124416: [SPIRV] Add the SPIRV-specific intrinsics, two passes and tests

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp:58-61
+  void preprocessCompositeConstants();
+  CallInst *buildIntrCall(Intrinsic::ID IntrID, ArrayRef<Type *> Types,
+                          ArrayRef<Value *> Args) {
+    auto *IntrFn = Intrinsic::getDeclaration(F->getParent(), IntrID, Types);
----------------
CreateUnaryIntrinsic?


================
Comment at: llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp:120-121
+static void setInsertPointSkippingPhis(IRBuilder<> &B, Instruction *I) {
+  while (isa<PHINode>(I))
+    I = I->getNextNode();
+  B.SetInsertPoint(I);
----------------
getFirstInsertionPt?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124416/new/

https://reviews.llvm.org/D124416