[compiler-rt] b3e8e43 - [compiler-rt][NFC] Inclusive language: remove use of sanity check/test
Quinn Pham via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 25 14:13:17 PDT 2022
Author: Quinn Pham
Date: 2022-04-25T16:13:11-05:00
New Revision: b3e8e43789d2f2d36dccd1edac3a2806cdebbbc0
URL: https://github.com/llvm/llvm-project/commit/b3e8e43789d2f2d36dccd1edac3a2806cdebbbc0
DIFF: https://github.com/llvm/llvm-project/commit/b3e8e43789d2f2d36dccd1edac3a2806cdebbbc0.diff
LOG: [compiler-rt][NFC] Inclusive language: remove use of sanity check/test
from compiler-rt/lib/tsan
[NFC] As part of using inclusive language within the llvm project, this
patch rewords comments to remove sanity check and sanity test.
Reviewed By: dvyukov
Differential Revision: https://reviews.llvm.org/D124390
Added:
Modified:
compiler-rt/lib/tsan/go/test.c
compiler-rt/lib/tsan/rtl-old/CMakeLists.txt
compiler-rt/lib/tsan/rtl-old/tsan_flags.cpp
compiler-rt/lib/tsan/rtl/CMakeLists.txt
compiler-rt/lib/tsan/rtl/tsan_flags.cpp
compiler-rt/lib/tsan/rtl/tsan_rtl.cpp
Removed:
################################################################################
diff --git a/compiler-rt/lib/tsan/go/test.c b/compiler-rt/lib/tsan/go/test.c
index 787b4c5b7dc19..1b0d828c90447 100644
--- a/compiler-rt/lib/tsan/go/test.c
+++ b/compiler-rt/lib/tsan/go/test.c
@@ -6,7 +6,7 @@
//
//===----------------------------------------------------------------------===//
//
-// Sanity test for Go runtime.
+// Test for Go runtime.
//
//===----------------------------------------------------------------------===//
diff --git a/compiler-rt/lib/tsan/rtl-old/CMakeLists.txt b/compiler-rt/lib/tsan/rtl-old/CMakeLists.txt
index 061f6c33690be..1f781c444ca12 100644
--- a/compiler-rt/lib/tsan/rtl-old/CMakeLists.txt
+++ b/compiler-rt/lib/tsan/rtl-old/CMakeLists.txt
@@ -172,7 +172,7 @@ else()
add_asm_sources(TSAN_ASM_SOURCES
tsan_rtl_amd64.S
)
- # Sanity check for Go runtime.
+ # Check for Go runtime.
set(BUILDGO_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/../go/buildgo.sh)
add_custom_target(GotsanRuntimeCheck
COMMAND env "CC=${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1}"
@@ -186,7 +186,7 @@ else()
add_asm_sources(TSAN_ASM_SOURCES
tsan_rtl_aarch64.S
)
- # Sanity check for Go runtime.
+ # Check for Go runtime.
set(BUILDGO_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/../go/buildgo.sh)
add_custom_target(GotsanRuntimeCheck
COMMAND env "CC=${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1}"
@@ -200,7 +200,7 @@ else()
add_asm_sources(TSAN_ASM_SOURCES
tsan_rtl_ppc64.S
)
- # Sanity check for Go runtime.
+ # Check for Go runtime.
set(BUILDGO_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/../go/buildgo.sh)
add_custom_target(GotsanRuntimeCheck
COMMAND env "CC=${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1}"
@@ -218,7 +218,7 @@ else()
add_asm_sources(TSAN_ASM_SOURCES
tsan_rtl_s390x.S
)
- # Sanity check for Go runtime.
+ # Check for Go runtime.
set(BUILDGO_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/../go/buildgo.sh)
add_custom_target(GotsanRuntimeCheck
COMMAND env "CC=${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1}"
diff --git a/compiler-rt/lib/tsan/rtl-old/tsan_flags.cpp b/compiler-rt/lib/tsan/rtl-old/tsan_flags.cpp
index ee89862d17bd8..2e8add3c8d431 100644
--- a/compiler-rt/lib/tsan/rtl-old/tsan_flags.cpp
+++ b/compiler-rt/lib/tsan/rtl-old/tsan_flags.cpp
@@ -97,7 +97,7 @@ void InitializeFlags(Flags *f, const char *env, const char *env_option_name) {
ubsan_parser.ParseStringFromEnv("UBSAN_OPTIONS");
#endif
- // Sanity check.
+ // Check flags.
if (!f->report_bugs) {
f->report_thread_leaks = false;
f->report_destroy_locked = false;
diff --git a/compiler-rt/lib/tsan/rtl/CMakeLists.txt b/compiler-rt/lib/tsan/rtl/CMakeLists.txt
index 0da2b89fd8079..e71268eea1fbc 100644
--- a/compiler-rt/lib/tsan/rtl/CMakeLists.txt
+++ b/compiler-rt/lib/tsan/rtl/CMakeLists.txt
@@ -169,7 +169,7 @@ else()
add_asm_sources(TSAN_ASM_SOURCES
tsan_rtl_amd64.S
)
- # Sanity check for Go runtime.
+ # Check for Go runtime.
set(BUILDGO_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/../go/buildgo.sh)
add_custom_target(GotsanRuntimeCheck
COMMAND env "CC=${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1}"
@@ -183,7 +183,7 @@ else()
add_asm_sources(TSAN_ASM_SOURCES
tsan_rtl_aarch64.S
)
- # Sanity check for Go runtime.
+ # Check for Go runtime.
set(BUILDGO_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/../go/buildgo.sh)
add_custom_target(GotsanRuntimeCheck
COMMAND env "CC=${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1}"
@@ -197,7 +197,7 @@ else()
add_asm_sources(TSAN_ASM_SOURCES
tsan_rtl_ppc64.S
)
- # Sanity check for Go runtime.
+ # Check for Go runtime.
set(BUILDGO_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/../go/buildgo.sh)
add_custom_target(GotsanRuntimeCheck
COMMAND env "CC=${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1}"
@@ -215,7 +215,7 @@ else()
add_asm_sources(TSAN_ASM_SOURCES
tsan_rtl_s390x.S
)
- # Sanity check for Go runtime.
+ # Check for Go runtime.
set(BUILDGO_SCRIPT ${CMAKE_CURRENT_SOURCE_DIR}/../go/buildgo.sh)
add_custom_target(GotsanRuntimeCheck
COMMAND env "CC=${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1}"
diff --git a/compiler-rt/lib/tsan/rtl/tsan_flags.cpp b/compiler-rt/lib/tsan/rtl/tsan_flags.cpp
index 54bed9f9a6be1..ee78f25cc65c4 100644
--- a/compiler-rt/lib/tsan/rtl/tsan_flags.cpp
+++ b/compiler-rt/lib/tsan/rtl/tsan_flags.cpp
@@ -97,7 +97,7 @@ void InitializeFlags(Flags *f, const char *env, const char *env_option_name) {
ubsan_parser.ParseStringFromEnv("UBSAN_OPTIONS");
#endif
- // Sanity check.
+ // Check flags.
if (!f->report_bugs) {
f->report_thread_leaks = false;
f->report_destroy_locked = false;
diff --git a/compiler-rt/lib/tsan/rtl/tsan_rtl.cpp b/compiler-rt/lib/tsan/rtl/tsan_rtl.cpp
index 45fa6d6f00c0a..1d6fc72526626 100644
--- a/compiler-rt/lib/tsan/rtl/tsan_rtl.cpp
+++ b/compiler-rt/lib/tsan/rtl/tsan_rtl.cpp
@@ -936,7 +936,7 @@ void TraceSwitchPartImpl(ThreadState* thr) {
// Pathologically large stacks may not fit into the part.
// In these cases we log only fixed number of top frames.
const uptr kMaxFrames = 1000;
- // Sanity check that kMaxFrames won't consume the whole part.
+ // Check that kMaxFrames won't consume the whole part.
static_assert(kMaxFrames < TracePart::kSize / 2, "kMaxFrames is too big");
uptr* pos = Max(&thr->shadow_stack[0], thr->shadow_stack_pos - kMaxFrames);
for (; pos < thr->shadow_stack_pos; pos++) {
More information about the llvm-commits
mailing list