[PATCH] D124413: [llvm-ml] Improve indirect call parsing

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:1110
                                OperandVector &FinalOperands);
-  bool ParseOperand(OperandVector &Operands);
+  bool ParseOperand(OperandVector &Operands, StringRef Name);
   bool ParseATTOperand(OperandVector &Operands);
----------------
Fix the function naming to use `lowerCase` while updating the signature.


================
Comment at: llvm/test/tools/llvm-ml/unconditional_branch_x64.asm:11
+jmp fn_ref
+; CHECK-LABEL: t0
+; CHECK: call qword ptr [rip + fn_ref]
----------------
t0 alone may not be unique in the output.


================
Comment at: llvm/test/tools/llvm-ml/unconditional_branch_x64.asm:61
+; CHECK-LABEL: t7
+; CHECK: call fn
+; CHECK: jmp fn
----------------
Consider `-NEXT:` if appropriate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124413/new/

https://reviews.llvm.org/D124413