[PATCH] D123394: [CodeGen] Late cleanup of redundant address/immediate definitions.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D123394#3472699 <https://reviews.llvm.org/D123394#3472699>, @jonpa wrote:

> AMDGPU tests updated.
>
> Some test updates I did not understand: 's_waitcnt_depctr 0xffe3' removed in cc-update.ll, flat-scratch.ll, ... . 's_clause 0x1' added in chain-hi-to-lo.ll..?
>
> How do I update test/CodeGen/AMDGPU/multilevel-break.ll?
> For the opt line, I get
> ../llvm/utils/update_test_checks.py --opt-binary ./bin/opt ../llvm/test/CodeGen/AMDGPU/multilevel-break.ll
>
>> WARNING: Skipping non-opt RUN line: llc -march=amdgcn -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s
>> WARNING: Change IR value name 'tmp43' or use --prefix-filecheck-ir-name to prevent possible conflict with scripted FileCheck name.
>
> And for llc line, I get
> ../llvm/utils/update_llc_test_checks.py --llc-binary ./bin/llc ../llvm/test/CodeGen/AMDGPU/multilevel-break.ll
>
>> WARNING: Skipping test which wasn't autogenerated by utils/update_llc_test_checks.py: ../llvm/test/CodeGen/AMDGPU/multilevel-break.ll

This is because update_llc_test_checks/update_test_checks have inconsistent behavior with multiple run lines. You basically have to delete one of the run lines, run the appropriate test check, and then swap the lines back before restoring both. Ideally we would have one update script that's smart enough to understand multiple output formats


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123394/new/

https://reviews.llvm.org/D123394