[PATCH] D122251: [lit] Use sharding for GoogleTest format

[Michael Platings via Phabricator via llvm-commits]

michaelplatings added a comment.

> But can this be reverted or made an off-by-default option until it can provide equivalent information & convenience?

I appreciate the speed improvement on Windows, but I'd like to second @sammccall's request.
Currently I'm intermittently getting the output below from my CI, and it's too opaque.

  Script(shard):
  --
  GTEST_COLOR=no
  GTEST_SHUFFLE=0
  GTEST_TOTAL_SHARDS=83
  GTEST_SHARD_INDEX=69
  GTEST_OUTPUT=json:/path/to/clang/unittests/Tooling/./ToolingTests-Clang-Unit-54664-69-83.json
  /path/to/clang/unittests/Tooling/./ToolingTests
  --
  shard JSON output does not exist: /path/to/clang/unittests/Tooling/./ToolingTests-Clang-Unit-54664-69-83.json

Something, somewhere is sometimes, somehow causing a crash but the information the test system provides is not helpful to figuring out what that is.
Given the choice between faster opaque tests and slower, more helpful ones I'd like the slower ones back please.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122251/new/

https://reviews.llvm.org/D122251