[PATCH] D122930: [Propeller] Promote functions with propeller profiles to .text.hot.

[Rahman Lavaee via Phabricator via llvm-commits]

rahmanl created this revision.
Herald added subscribers: hiraditya, arichardson, mgorny, emaste.
Herald added a reviewer: MaskRay.
Herald added a project: All.
Herald added a subscriber: StephenFan.
rahmanl updated this revision to Diff 424581.
rahmanl added a comment.
rahmanl retitled this revision from "Add propeller functions to their own sections." to "[Propeller] Promote functions with propeller profiles to .text.hot.".
rahmanl edited the summary of this revision.
Herald added a subscriber: wenlei.
rahmanl updated this revision to Diff 424647.
Herald added a subscriber: pengfei.
rahmanl updated this revision to Diff 424648.
rahmanl edited the summary of this revision.
rahmanl added a reviewer: tmsriram.
rahmanl added subscribers: shenhan, amharc, vporpo.
rahmanl published this revision for review.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Refactor code.


rahmanl added a comment.

WIP.


rahmanl added a comment.

Fix comment.


Today, text section prefixes (none, .unlikely, .hot, and .unkown) are determined based on PGO profile. However, Propeller may deem a function hot when PGO doesn't. Besides, when `-Wl,-keep-text-section-prefix=true` Propeller cannot enforce a global section ordering as the linker can only reorder sections within each output section (.text, .text.hot, .text.unlikely).

This patch promotes all functions with Propeller profiles (functions listed in the basic-block-sections profile) to .text.hot.

The new implementation refactors the parsing of basic block sections profile into a new BasicBlockSectionsInfo analysis pass. This allows us to use the information earlier in CodeGenPrepare in order to set the functions text prefix.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D122930

Files:
  llvm/include/llvm/Analysis/BasicBlockSectionsInfo.h
  llvm/include/llvm/Analysis/Passes.h
  llvm/include/llvm/CodeGen/Passes.h
  llvm/include/llvm/InitializePasses.h
  llvm/lib/Analysis/BasicBlockSectionsInfo.cpp
  llvm/lib/Analysis/CMakeLists.txt
  llvm/lib/CodeGen/BasicBlockSections.cpp
  llvm/lib/CodeGen/CodeGenPrepare.cpp
  llvm/lib/CodeGen/TargetPassConfig.cpp
  llvm/test/CodeGen/X86/basic-block-sections-cold.ll
  llvm/test/CodeGen/X86/basic-block-sections-list.ll
  llvm/test/CodeGen/X86/basic-block-sections-listbb.ll
  llvm/test/CodeGen/X86/basic-block-sections-source-drift.ll
  llvm/test/CodeGen/X86/opt-pipeline.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122930.424648.patch
Type: text/x-patch
Size: 30366 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220425/052fb44b/attachment.bin>