[PATCH] D112531: [RFC][DataLayout] Allow vector specifications by element size

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/IR/DataLayout.cpp:833
   case Type::ScalableVectorTyID: {
-    unsigned BitWidth = getTypeSizeInBits(Ty).getKnownMinSize();
-    auto I = findAlignmentLowerBound(VECTOR_ALIGN, BitWidth);
-    if (I != Alignments.end() && I->AlignType == VECTOR_ALIGN &&
-        I->TypeBitWidth == BitWidth)
-      return abi_or_pref ? I->ABIAlign : I->PrefAlign;
+    // FIXME: Can X86_MMXTyID and VectorsByEltSize coexist?
+    Optional<unsigned> BitWidth;
----------------
X86_MMXTyID is specifically for x86, so it's not likely to come up in practice... but should be fine to compute the alignment as if the element type is i64.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112531/new/

https://reviews.llvm.org/D112531