[PATCH] D124178: [ArgPromotion] Change the condition to check the promotion limit

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/ArgumentPromotion.h:28
 public:
-  ArgumentPromotionPass(unsigned MaxElements = 3u) : MaxElements(MaxElements) {}
+  ArgumentPromotionPass(unsigned MaxElements = 2u) : MaxElements(MaxElements) {}
 
----------------
`MaxElements` is also used elsewhere (handling byval args) besides the one place below.

I think making the two uses consistent makes sense and should be ok, but that should be noted in the description (this doesn't preserve existing behavior as currently stated). if somebody complains about this regressing anything, we can split `MaxElement` into two separate parameters


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124178/new/

https://reviews.llvm.org/D124178