[PATCH] D124392: [AIX][XCOFF] error on emit symbol visibility for XCOFF object file

Digger Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 25 08:46:42 PDT 2022


DiggerLin accepted this revision.
DiggerLin added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:681
+  if (SymbolType != 0)
+    report_fatal_error("Cannot emit non-zero visibility yet.");
   // TODO Set the function indicator (bit 10, 0x0020) for functions
----------------
minor. I am not sure whether it is better to "Emitting non-zero visibility are not supported yet" or not.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124392/new/

https://reviews.llvm.org/D124392



More information about the llvm-commits mailing list