[PATCH] D124362: [NFC] [Pipelines] Hoist CoroCleanup as Module Pass (3/5)
Arthur Eubanks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 25 08:24:39 PDT 2022
aeubanks added inline comments.
================
Comment at: llvm/lib/Transforms/Coroutines/CoroCleanup.cpp:57
-bool Lowerer::lowerRemainingCoroIntrinsics(Function &F) {
- bool Changed = false;
-
----------------
why are we removing `Changed` and always invalidating analyses? if we have a module where most functions don't call any of these intrinsics, we're going to unnecessarily invalidate a lot more analyses which will be bad for compile times.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124362/new/
https://reviews.llvm.org/D124362
More information about the llvm-commits
mailing list