[PATCH] D124358: [LV][SLP] Mark fptosi_sat as vectorizable

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/include/llvm/Analysis/VectorUtils.h:320
 /// an overloaded type.
-bool hasVectorInstrinsicOverloadedScalarOpd(Intrinsic::ID ID,
-                                            unsigned ScalarOpdIdx);
+bool hasVectorInstrinsicOverloadedOpd(Intrinsic::ID ID, unsigned OpdIdx);
 
----------------
Existing typo in the names here and above - "Instrinsic" -> "Intrinsic".
On top of that, these function names don't read clearly to me, so if we're changing things anyway, maybe we can do better.
"isVectorIntrinsicWithScalarOpAtArg"
"isVectorIntrinsicWithDifferentTypeAtArg"

This still seems out-of-place...maybe it should be an introspective function of IntrinsicInst instead - "getTypeForArgNum"?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124358/new/

https://reviews.llvm.org/D124358