[PATCH] D124153: [CMake] Change default CMAKE_BUILD_TYPE to Release

Mon Apr 25 05:52:27 PDT 2022

erichkeane added a comment.

In D124153#3471155 <https://reviews.llvm.org/D124153#3471155>, @thieta wrote:

> One thing we all seem to agree on is that documentation could be better - so I took a stab at that here - I think it's connected to this discussion, but I don't think it's the only fix, please see the doc suggestions here: https://reviews.llvm.org/D124367
>
> I am currently leaning towards:
>
> - Improve documentation
> - Make omitting CMAKE_BUILD_TYPE a error. I am also fine with changing it to Release, but I don't have a strong opinion either way. I do think keeping Debug is worse than both options. But it can be made better by point 3 here:
> - Add an error when trying to use Debug + bfd linker to catch the most common problem, especially if we keep Debug the default.

I'm OK with #1 and #2, but note that the combo in #3 is not ALWAYS broken, just if you don't have enough memory or are running too many link jobs at the same time.  I'm not sure we want it to be an 'error'.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124153/new/

https://reviews.llvm.org/D124153