[PATCH] D124194: [AMDGPU] Correctly set `IsKill` flag for VGPR custom spills in the prolog

Christudasan Devadasan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 25 04:17:22 PDT 2022


cdevadas added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/track-spilled-vgpr-liveness.mir:1
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+# RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx906 -run-pass=prologepilog -verify-machineinstrs %s -o - | FileCheck -check-prefix=GCN %s
----------------
foad wrote:
> Can you precommit this test so we can see the diff?
Prior to this patch, the test would end up with a verifier error complaining undefined register used.
It is because we unconditionally mark 'killed'  for the register in the prolog spill and the use following that will be flagged by the verifier.
 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124194/new/

https://reviews.llvm.org/D124194



More information about the llvm-commits mailing list