[PATCH] D124326: [AArch64][SVE] Fix assertions when vectorizing Freeze Instructions

Mon Apr 25 03:37:16 PDT 2022

david-arm added a reviewer: fhahn.
david-arm added a comment.

Hi @lizhijin, I'm not sure if this is really the right strategy here. From what I can tell the freeze instruction can be widened normally, so it feels wrong to have a special case for it in the VPReplicateRecipe. Can we not just ensure we choose the right vplan in the first place, i.e. VPWidenRecipe?

================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/vector-freeze-sve.ll:13
+define void @_Z14PDF_NameEncodeRK14CFX_ByteString() #1 personality i8* undef {
+; CHECK-LABEL: @_Z14PDF_NameEncodeRK14CFX_ByteString(
+; CHECK:    ret void
----------------
Can you add more CHECK lines here please? It doesn't really seem to be defending anything except that the compiler doesn't crash. Perhaps at least add CHECK lines for a vector.body and the freeze instruction?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124326/new/

https://reviews.llvm.org/D124326