[PATCH] D123978: [RISCV] Support getHostCpuName for sifive-u74

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 25 00:14:10 PDT 2022


MaskRay added inline comments.


================
Comment at: llvm/lib/Support/Host.cpp:385
+  // There are 24 lines in /proc/cpuinfo
+  SmallVector<StringRef, 24> Lines;
+  ProcCpuinfoContent.split(Lines, "\n");
----------------
It's unnecessary to optimize for avoiding the memory allocation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123978/new/

https://reviews.llvm.org/D123978



More information about the llvm-commits mailing list