[PATCH] D124014: [AArch64] Correct isLegalAddressingMode for ldp/stp

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 24 23:29:57 PDT 2022


dmgreen added a comment.

In D124014#3470289 <https://reviews.llvm.org/D124014#3470289>, @bcl5980 wrote:

> @dmgreen , do I need to add a todo and check in the test after clean?

I'm not sure about a TODO. Where would it be added? I find they tend to bitrot and muddle the code, more then they help sometimes.

Having a test sounds useful, to show inefficiencies that can be fixed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124014/new/

https://reviews.llvm.org/D124014



More information about the llvm-commits mailing list