[PATCH] D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-dwarfutil/llvm-dwarfutil.cpp:498
+
+  Expected<FilePermissionsApplier> PermsCarrier =
+      FilePermissionsApplier::create(Opts.InputFileName);
----------------
Similar to how I suggested the class be renamed to `FilePermissionsApplier` from `FilePermissionsCarrier`, I think you should use the word "Applier" in the variable name instead of "Carrier". I also think you should add the "OrErr" suffix, like in `BinOrErr`, so the new name would be `PermsApplierOrErr`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86539/new/

https://reviews.llvm.org/D86539