[PATCH] D124342: [X86][AMX] Report error when shapes are not pre-defined.

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:315-316
+      // would not config tile registers.
+      emitErrorMsg(MF);
+      return false;
+    }
----------------
xiangzhangllvm wrote:
> I think we should stop compiling or at lest let it not generate out file.
> Because the error message may be redirect to a log file. Users may not check it.
The error handler would indicate compiler not generate out file. If there is no error handler, compiler would exit. Pls try clang or llc.
As Phoebe mentions, exit is not a normal way in backend, so I just let the compiling continue but the tile config doesn't happen. Finally compiler would remove the output file. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124342/new/

https://reviews.llvm.org/D124342