[PATCH] D124342: [X86][AMX] Report error when shapes are not pre-defined.

LuoYuanke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 24 03:07:32 PDT 2022


LuoYuanke added inline comments.


================
Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:52
+  Context.emitError(ErrorMsg);
+  exit(1);
+}
----------------
pengfei wrote:
> Any benefit to use `exit`? I found we seldom use it in the code.
Ok, let's depend on emitError to handle the error. Let me remove `exit`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124342/new/

https://reviews.llvm.org/D124342



More information about the llvm-commits mailing list